[PULP-1693] Add package blocklist to Python repos#1392
Open
[PULP-1693] Add package blocklist to Python repos#1392
Conversation
closes pulp#1391 Assisted By: Claude Opus 4.6
mdellweg
reviewed
May 8, 2026
| return self.call("repair_metadata", parameters={self.HREF: self.pulp_href}) | ||
|
|
||
|
|
||
| class PulpPythonRepositoryBlocklistEntryContext(PulpEntityContext): |
Member
There was a problem hiding this comment.
Suggested change
| class PulpPythonRepositoryBlocklistEntryContext(PulpEntityContext): | |
| class PulpPythonBlocklistEntryContext(PulpEntityContext): |
I don't think the "repository" in there adds any information or helps distinguishing things.
|
|
||
|
|
||
| blocklist.add_command(list_command(decorators=nested_lookup_options)) | ||
| blocklist.add_command(show_command(decorators=nested_lookup_options + [href_option])) |
Member
There was a problem hiding this comment.
This doesn't look right. How do you identify a blocklist on a repository?
Can a repository have more than one blocklist?
| blocklist.add_command(list_command(decorators=nested_lookup_options)) | ||
| blocklist.add_command(show_command(decorators=nested_lookup_options + [href_option])) | ||
| blocklist.add_command( | ||
| destroy_command(name="remove", decorators=nested_lookup_options + [href_option]) |
Member
There was a problem hiding this comment.
This also looks like suboptimal ux.
You should be able to remove entries on the blocklist by specifying the name and version IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1391